On Thu, 16 Oct 2025, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > The i915_gem_object_get_frontbuffer() name is rather confusing wrt. > intel_frontbuffer_get(). Rename to i915_gem_object_frontbuffer_lookup() > to make things less confusing. > > Acked-by: Jani Nikula <[email protected]>
Upgrade to Reviewed-by: Jani Nikula <[email protected]> > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 4 ++-- > drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.c | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h | 6 +++--- > drivers/gpu/drm/i915/i915_vma.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c > b/drivers/gpu/drm/i915/gem/i915_gem_object.c > index 36680eddf88e..828936e603a6 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c > @@ -478,7 +478,7 @@ void __i915_gem_object_flush_frontbuffer(struct > drm_i915_gem_object *obj, > { > struct i915_frontbuffer *front; > > - front = i915_gem_object_get_frontbuffer(obj); > + front = i915_gem_object_frontbuffer_lookup(obj); > if (front) { > intel_frontbuffer_flush(&front->base, origin); > i915_gem_object_frontbuffer_put(front); > @@ -490,7 +490,7 @@ void __i915_gem_object_invalidate_frontbuffer(struct > drm_i915_gem_object *obj, > { > struct i915_frontbuffer *front; > > - front = i915_gem_object_get_frontbuffer(obj); > + front = i915_gem_object_frontbuffer_lookup(obj); > if (front) { > intel_frontbuffer_invalidate(&front->base, origin); > i915_gem_object_frontbuffer_put(front); > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.c > b/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.c > index 7ef89613c025..aaa15e7b3f17 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.c > @@ -28,7 +28,7 @@ i915_gem_object_frontbuffer_get(struct drm_i915_gem_object > *obj) > struct drm_i915_private *i915 = to_i915(obj->base.dev); > struct i915_frontbuffer *front, *cur; > > - front = i915_gem_object_get_frontbuffer(obj); > + front = i915_gem_object_frontbuffer_lookup(obj); > if (front) > return front; > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h > b/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h > index 385f7e8049b8..2133e29047c5 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h > @@ -46,8 +46,8 @@ void i915_gem_object_frontbuffer_ref(struct > i915_frontbuffer *front); > void i915_gem_object_frontbuffer_put(struct i915_frontbuffer *front); > > /** > - * i915_gem_object_get_frontbuffer - Get the object's frontbuffer > - * @obj: The object whose frontbuffer to get. > + * i915_gem_object_frontbuffer_lookup - Look up the object's frontbuffer > + * @obj: The object whose frontbuffer to look up. > * > * Get pointer to object's frontbuffer if such exists. Please note that RCU > * mechanism is used to handle e.g. ongoing removal of frontbuffer pointer. > @@ -55,7 +55,7 @@ void i915_gem_object_frontbuffer_put(struct > i915_frontbuffer *front); > * Return: pointer to object's frontbuffer is such exists or NULL > */ > static inline struct i915_frontbuffer * > -i915_gem_object_get_frontbuffer(const struct drm_i915_gem_object *obj) > +i915_gem_object_frontbuffer_lookup(const struct drm_i915_gem_object *obj) > { > struct i915_frontbuffer *front; > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index cb36daaa101d..6888d3f4557b 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -1992,7 +1992,7 @@ int _i915_vma_move_to_active(struct i915_vma *vma, > if (flags & EXEC_OBJECT_WRITE) { > struct i915_frontbuffer *front; > > - front = i915_gem_object_get_frontbuffer(obj); > + front = i915_gem_object_frontbuffer_lookup(obj); > if (unlikely(front)) { > if (intel_frontbuffer_invalidate(&front->base, > ORIGIN_CS)) > i915_active_add_request(&front->write, rq); -- Jani Nikula, Intel
