On Mon, Nov 03, 2025 at 02:59:29PM +0100, Eric Auger wrote: > Hi Jason, > > On 10/24/25 1:09 AM, Jason Gunthorpe wrote: > > Move it out of vfio_platform_ioctl() and re-indent it. Add it to all > > platform drivers. > > > > Signed-off-by: Jason Gunthorpe <[email protected]> > > --- > > drivers/vfio/platform/vfio_amba.c | 1 + > > drivers/vfio/platform/vfio_platform.c | 1 + > > drivers/vfio/platform/vfio_platform_common.c | 50 +++++++++++-------- > > drivers/vfio/platform/vfio_platform_private.h | 2 + > > 4 files changed, 32 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/vfio/platform/vfio_amba.c > > b/drivers/vfio/platform/vfio_amba.c > > index 9f5c527baa8a36..d600deaf23b6d7 100644 > > --- a/drivers/vfio/platform/vfio_amba.c > > +++ b/drivers/vfio/platform/vfio_amba.c > > @@ -115,6 +115,7 @@ static const struct vfio_device_ops vfio_amba_ops = { > > .open_device = vfio_platform_open_device, > > .close_device = vfio_platform_close_device, > > .ioctl = vfio_platform_ioctl, > > + .get_region_info = vfio_platform_ioctl_get_region_info,
> Any rationale behind why using _ioctl naming in some drivers and not in > some others? No, I was making changes sort of in line to the code that was already there.. The _ioctl_ came from PCI where I had labeled all the sub functions that broke out of the ioctl function with _ioctl_ to make it clear they were part of those system calls. I guess these can have _ioctl_ added in: drivers/gpu/drm/i915/gvt/kvmgt.c: .get_region_info_caps = intel_vgpu_get_region_info, drivers/s390/cio/vfio_ccw_ops.c: .get_region_info_caps = vfio_ccw_mdev_get_region_info, drivers/vfio/fsl-mc/vfio_fsl_mc.c: .get_region_info_caps = vfio_fsl_mc_get_region_info, drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c: .get_region_info_caps = hisi_acc_vfio_get_region, samples/vfio-mdev/mbochs.c: .get_region_info_caps = mbochs_get_region_info, drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/pci/mlx5/main.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/pci/nvgrace-gpu/main.c: .get_region_info_caps = nvgrace_gpu_ioctl_get_region_info, drivers/vfio/pci/nvgrace-gpu/main.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/pci/pds/vfio_dev.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/cdx/main.c: .get_region_info_caps = vfio_cdx_ioctl_get_region_info, drivers/vfio/pci/qat/main.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/pci/vfio_pci.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/pci/virtio/main.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/pci/virtio/main.c: .get_region_info_caps = virtiovf_pci_ioctl_get_region_info, drivers/vfio/pci/virtio/main.c: .get_region_info_caps = vfio_pci_ioctl_get_region_info, drivers/vfio/platform/vfio_amba.c: .get_region_info_caps = vfio_platform_ioctl_get_region_info, drivers/vfio/platform/vfio_platform.c: .get_region_info_caps = vfio_platform_ioctl_get_region_info, samples/vfio-mdev/mdpy.c: .get_region_info_caps = mdpy_ioctl_get_region_info, samples/vfio-mdev/mtty.c: .get_region_info_caps = mtty_ioctl_get_region_info, Thanks, Jason
