On Fri, Nov 14, 2025 at 12:26:45PM +0200, Jani Nikula wrote:
> Prefer the more generic pointer rather than i915 specific data
> type. Also use dma_fence_put() for symmetry with the dma_fence_get()
> 
> Signed-off-by: Jani Nikula <[email protected]>

Reviewed-by: Ville Syrjälä <[email protected]>

> ---
>  drivers/gpu/drm/i915/display/intel_display_rps.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_rps.c 
> b/drivers/gpu/drm/i915/display/intel_display_rps.c
> index 82ea1ec482e4..b6720f7c09d9 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_rps.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_rps.c
> @@ -18,14 +18,14 @@ struct wait_rps_boost {
>       struct wait_queue_entry wait;
>  
>       struct drm_crtc *crtc;
> -     struct i915_request *request;
> +     struct dma_fence *fence;
>  };
>  
>  static int do_rps_boost(struct wait_queue_entry *_wait,
>                       unsigned mode, int sync, void *key)
>  {
>       struct wait_rps_boost *wait = container_of(_wait, typeof(*wait), wait);
> -     struct i915_request *rq = wait->request;
> +     struct i915_request *rq = to_request(wait->fence);
>  
>       /*
>        * If we missed the vblank, but the request is already running it
> @@ -34,7 +34,7 @@ static int do_rps_boost(struct wait_queue_entry *_wait,
>        */
>       if (!i915_request_started(rq))
>               intel_rps_boost(rq);
> -     i915_request_put(rq);
> +     dma_fence_put(wait->fence);
>  
>       drm_crtc_vblank_put(wait->crtc);
>  
> @@ -64,7 +64,7 @@ void intel_display_rps_boost_after_vblank(struct drm_crtc 
> *crtc,
>               return;
>       }
>  
> -     wait->request = to_request(dma_fence_get(fence));
> +     wait->fence = dma_fence_get(fence);
>       wait->crtc = crtc;
>  
>       wait->wait.func = do_rps_boost;
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel

Reply via email to