On 11/20/2025 2:21 PM, Michał Grzelak wrote:
Hi Ankit,
On Wed, 19 Nov 2025, Ankit Nautiyal wrote:
Currently intel_alpm_lobf_compute_config() tries to account for
guardband +SCL requirements during encoder->compute_config() phase,
even before guardband is computed.
Also, LOBF depends on crtc_state->has_psr which can be modified in
encoder->compute_config_late().
Account for lobf requirements while optimizing the guardband and add
checks for final guardband in encoder->compute_config_late() phase after
the guardband and the final state of crtc_state->has_psr are already
computed.
Use crtc_state->vrr.guardband and crtc_state->set_context_latency for
the computation and add more documentation for the dependency of first
sdp position, guardband, set context latency and wake lines.
v2: Add helper to use min guardband required for lobf.
Bspec:71041
Signed-off-by: Ankit Nautiyal <[email protected]>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 63 +++++++++++++++++-----
drivers/gpu/drm/i915/display/intel_alpm.h | 3 ++
drivers/gpu/drm/i915/display/intel_dp.c | 2 +
drivers/gpu/drm/i915/display/intel_intel.c | 0
[...]
diff --git a/drivers/gpu/drm/i915/display/intel_intel.c
b/drivers/gpu/drm/i915/display/intel_intel.c
new file mode 100644
index 000000000000..e69de29bb2d1
Nitpick, but it looks like an empty file named intel_intel.c stepped
into the patch, which is also seen in the above shortlog. Otherwise,
Oops! I thought I fixed that from last version.
Thanks for catching this.
Regards,
Ankit
Reviewed-by: Michał Grzelak <[email protected]>
BR,
Michał
