Hi, I am not sure about fixing these dim checkpatch errors because are from the original code. Dave, do you any thoughts? Can we ignore these?
thanks, - Joel On 11/25/2025 2:50 PM, Patchwork wrote: > [You don't often get email from [email protected]. Learn why > this is important at https://aka.ms/LearnAboutSenderIdentification ] > > == Series Details == > > Series: gpu: Move DRM buddy allocator one level up > URL : https://patchwork.freedesktop.org/series/158061/ > State : warning > > == Summary == > > Error: dim checkpatch failed > e9e4c6aaaf8d gpu: Move DRM buddy allocator one level up > -:39: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does > MAINTAINERS need updating? > #39: > new file mode 100644 > > -:51: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully > describes the config symbol with at least 4 lines > #51: FILE: drivers/gpu/Kconfig:8: > +config GPU_BUDDY_KUNIT_TEST > + tristate "KUnit tests for GPU buddy allocator" if !KUNIT_ALL_TESTS > + depends on GPU_BUDDY && KUNIT > + default KUNIT_ALL_TESTS > + help > + KUnit tests for the GPU buddy allocator. > > -:95: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #95: FILE: drivers/gpu/buddy.c:23: > + BUG_ON(order > GPU_BUDDY_MAX_ORDER); > > -:107: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #107: FILE: drivers/gpu/buddy.c:35: > + BUG_ON(block->header & GPU_BUDDY_HEADER_UNUSED); > > -:382: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #382: FILE: drivers/gpu/buddy.c:310: > + BUG_ON(mm->max_order > GPU_BUDDY_MAX_ORDER); > > -:427: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #427: FILE: drivers/gpu/buddy.c:355: > + BUG_ON(root_count > mm->max_order); > > -:428: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #428: FILE: drivers/gpu/buddy.c:356: > + BUG_ON(gpu_buddy_block_size(mm, root) < chunk_size); > > -:494: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #494: FILE: drivers/gpu/buddy.c:422: > + BUG_ON(!gpu_buddy_block_is_free(block)); > > -:495: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #495: FILE: drivers/gpu/buddy.c:423: > + BUG_ON(!gpu_buddy_block_order(block)); > > -:597: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #597: FILE: drivers/gpu/buddy.c:525: > + BUG_ON(!gpu_buddy_block_is_allocated(block)); > > -:845: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #845: FILE: drivers/gpu/buddy.c:773: > + BUG_ON(!gpu_buddy_block_is_free(block)); > > -:1221: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #1221: FILE: drivers/gpu/buddy.c:1149: > + BUG_ON(order > mm->max_order); > > -:1222: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #1222: FILE: drivers/gpu/buddy.c:1150: > + BUG_ON(order < min_order); > > -:1348: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #1348: FILE: drivers/gpu/buddy.c:1276: > + BUG_ON(!gpu_buddy_block_is_free(block)); > > -:3135: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' > #3135: FILE: drivers/gpu/drm/drm_buddy.c:40: > + drm_printf( > > -:3149: ERROR:OPEN_BRACE: that open brace { should be on the previous line > #3149: FILE: drivers/gpu/drm/drm_buddy.c:52: > + for_each_free_tree(tree) > + { > > -:3157: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of > BUG() or variants > #3157: FILE: drivers/gpu/drm/drm_buddy.c:58: > + BUG_ON(!gpu_buddy_block_is_free(block)); > > -:5364: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tree' - possible > side-effects? > #5364: FILE: include/linux/gpu_buddy.h:28: > +#define for_each_free_tree(tree) \ > + for ((tree) = 0; (tree) < GPU_BUDDY_MAX_FREE_TREES; (tree)++) > > total: 1 errors, 15 warnings, 2 checks, 5201 lines checked > >
