> -----Original Message-----
> From: Intel-xe <[email protected]> On Behalf Of Jani
> Nikula
> Sent: Wednesday, November 26, 2025 4:41 PM
> To: [email protected]; [email protected]
> Cc: Nikula, Jani <[email protected]>; [email protected]
> Subject: [RESEND 3/4] drm/{i915,xe}/dsb: make struct intel_dsb_buffer
> opaque
>
> Move the definitions of struct intel_dsb_buffer to the driver specific files,
> hiding the implementation details from the shared DSB code.
>
> Signed-off-by: Jani Nikula <[email protected]>
LGTM.
Reviewed-by: Animesh Manna <[email protected]>
> ---
> drivers/gpu/drm/i915/display/intel_dsb_buffer.c | 6 ++++++
> drivers/gpu/drm/i915/display/intel_dsb_buffer.h | 8 +-------
> drivers/gpu/drm/xe/display/xe_dsb_buffer.c | 6 ++++++
> 3 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb_buffer.c
> b/drivers/gpu/drm/i915/display/intel_dsb_buffer.c
> index fc1f0e6031ba..50faf3869b6c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb_buffer.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb_buffer.c
> @@ -9,6 +9,12 @@
> #include "i915_vma.h"
> #include "intel_dsb_buffer.h"
>
> +struct intel_dsb_buffer {
> + u32 *cmd_buf;
> + struct i915_vma *vma;
> + size_t buf_size;
> +};
> +
> u32 intel_dsb_buffer_ggtt_offset(struct intel_dsb_buffer *dsb_buf) {
> return i915_ggtt_offset(dsb_buf->vma); diff --git
> a/drivers/gpu/drm/i915/display/intel_dsb_buffer.h
> b/drivers/gpu/drm/i915/display/intel_dsb_buffer.h
> index 2cf639fae47a..d746c872e0c7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb_buffer.h
> +++ b/drivers/gpu/drm/i915/display/intel_dsb_buffer.h
> @@ -9,13 +9,7 @@
> #include <linux/types.h>
>
> struct drm_device;
> -struct i915_vma;
> -
> -struct intel_dsb_buffer {
> - u32 *cmd_buf;
> - struct i915_vma *vma;
> - size_t buf_size;
> -};
> +struct intel_dsb_buffer;
>
> u32 intel_dsb_buffer_ggtt_offset(struct intel_dsb_buffer *dsb_buf); void
> intel_dsb_buffer_write(struct intel_dsb_buffer *dsb_buf, u32 idx, u32 val);
> diff --git a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> index ee7717b1980f..d55858705106 100644
> --- a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> +++ b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> @@ -9,6 +9,12 @@
> #include "xe_device.h"
> #include "xe_device_types.h"
>
> +struct intel_dsb_buffer {
> + u32 *cmd_buf;
> + struct i915_vma *vma;
> + size_t buf_size;
> +};
> +
> u32 intel_dsb_buffer_ggtt_offset(struct intel_dsb_buffer *dsb_buf) {
> return xe_bo_ggtt_addr(dsb_buf->vma->bo);
> --
> 2.47.3
