Re: [PATCH v9 04/17] drm/i915/vrr: Add functions to read out vmin/vmax stuff

[Jani Nikula]

On Thu, 27 Nov 2025, Mitul Golani <mitulkumar.ajitkumar.gol...@intel.com> wrote:
> +int intel_vrr_dcb_vmin_vblank_start_next(const struct intel_crtc_state 
> *crtc_state)
> +{
> +     struct intel_display *display = to_intel_display(crtc_state);
> +     enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
> +     u32 tmp = 0;
> +
> +     tmp = intel_de_read(display, 
> TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_LIVE(cpu_transcoder));
> +
> +     if (REG_FIELD_GET(VRR_DCB_ADJ_FLIPLINE_CNT_MASK, tmp) == 0)
> +             return -1;

My pet peeve, using magic -1 as a negative error code.


BR,
Jani.


-- 
Jani Nikula, Intel