On Friday, 28 November 2025 22:39:42 Central European Standard Time Patchwork wrote: > == Series Details == > > Series: Add new general DRM property "color format" (rev2) > URL : https://patchwork.freedesktop.org/series/157910/ > State : warning
I will fix most of these (I guess the CI uses a different checkpatch preset than b4 prep --check, had only one of these) but there's three that I won't address because they're stupid: > > == Summary == > > [snip] > b979329d91af drm/bridge: Act on the DRM color format property > -:73: WARNING:ENOTSUPP: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP > #73: FILE: drivers/gpu/drm/drm_bridge.c:1182: > + ret = -ENOTSUPP; > > total: 0 errors, 1 warnings, 0 checks, 57 lines checked The whole point of using -ENOTSUPP here is that it's the same return code as other branches in drm_atomic_bridge_chain_select_bus_fmts already take, and the caller already handles. > [snip] > 943216634f10 drm/tests: hdmi: Add tests for the color_format property > -:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #90: FILE: drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c:2036: > + priv = drm_kunit_helper_connector_hdmi_init_with_edid_funcs(test, > + BIT(HDMI_COLORSPACE_RGB) | > [snip] > -:133: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #133: FILE: drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c:2079: > + priv = drm_kunit_helper_connector_hdmi_init_with_edid_funcs(test, > + BIT(HDMI_COLORSPACE_RGB) | > > total: 0 errors, 0 warnings, 4 checks, 150 lines checked > This is a big "no" from me. I'm not going to align stuff to the opening brace when function names are so long they take up almost the entire line, and it seems every other invocation in this file agrees with me here.
