On Thu, Jan 08, 2026 at 03:12:03PM -0500, Rodrigo Vivi wrote: > From: Ben Dooks <[email protected]> > > The guc_hw_reg_state array is not exported, so make it static. > Fixes the following sparse warning: > drivers/gpu/drm/i915/i915_gpu_error.c:692:3: warning: symbol > 'guc_hw_reg_state' was not declared. Should it be static? > > Fixes: ba391a102ec11 ("drm/i915/guc: Include the GuC registers in the error > state")
next time, consider also Cc'ing the original author to speed up things: Cc: Daniele Ceraolo Spurio <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> pushing right now to drm-intel-next > Signed-off-by: Ben Dooks <[email protected]> > Signed-off-by: Rodrigo Vivi <[email protected]> > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c > b/drivers/gpu/drm/i915/i915_gpu_error.c > index 7582ef34bf3f..303d8d9b7775 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -686,7 +686,7 @@ static void err_print_guc_ctb(struct > drm_i915_error_state_buf *m, > } > > /* This list includes registers that are useful in debugging GuC hangs. */ > -const struct { > +static const struct { > u32 start; > u32 count; > } guc_hw_reg_state[] = { > -- > 2.52.0 >
