Hi Janusz, > The smem-oom subtest can expectedly result in oom-killer being triggered, > which then dumps a call trace from a process that triggered it. If that > happens to be a process that executes drm or i915 functions then the call > trace dump contains lines recognized by igt_runner running in piglit mode > as potential warnings. If severity of the call trace dump messages is > NOTICE or higher, which isn't unlikely, then a dmesg-warn result is > reported despite successful completion of the subtest. > > Fortunately, severity of those call trace dump messages depends on kernel > default log level which can be controlled from user space over sysctl. > > To avoid false failure reports, relax kernel default log level to INFO so > those log lines are ignored by igt_runner in piglit mode at an expense of > call traces from real issues potentially detected by the subtest not > contributing to the igt_runner reported result. Since those call traces > are still available to developers, only submitted with reduced severity, > that shouldn't hurt as long as the igt_runner still abandons further > execution and reports an abort result on a kernel taint. > > v4: In the exit handler, restore the default log level with a simple > write() from a formerly prepared buffer, and abort verbosely if that > doesn't succeed (Kamil). > v3: Move cleanup to an exit handler in case we are killed (Kamil). > v2: Move default log level setup inside subtest smem-oom (Kamil), > - move cleanup there as well. > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493 > Cc: Kamil Konieczny <[email protected]> > Signed-off-by: Janusz Krzysztofik <[email protected]> > ---
Reviewed-by: Krzysztof Karas <[email protected]> -- Best Regards, Krzysztof
