> As discussed previously, your patch will regress older MacBook Airs > which use SPI to access keyboard + trackpad if the set_os protocol > is invoked: > > https://lore.kernel.org/all/[email protected]/ > > The last time this topic came up, I suggested counting the number of > GPUs instead of using the DMI quirk. I even provided a patch but > nobody with an eGPU bothered to test it, so the thread fizzled out: > > https://lore.kernel.org/all/[email protected]/ > > Maybe you could give it a spin and verify if it fixes the issue for you?
I tested your patch, and well it works (you still need the 2nd patch to avoid a blank screen), but i can see how this will fail like for example, with the iMacPro (only has dGPU) you would need 2 eGPUs to turn on apple-set-os. My opinion is, we disable apple-set-os using a dmi check on the 2013/2014 MacbookAir models.
