Hi Krzysztof,
[...]
> +__live_work_confirm_finished(struct drm_i915_private *i915,
> + struct live_active *active)
> +{
> + int err = 0;
> +
> + if (!active->work_finished) {
> + struct drm_printer p = drm_err_printer(&i915->drm, __func__);
> +
> + drm_printf(&p, "active->work hasn't finished, something went\
> + terribly wrong\n");
I think "something went terribly wrong" is superfluous, when you
are not sure what the "something" was, so you could skip
printing that part. This is a non-blocking suggestion, include
it if you plan to prepare a v5 of this patch.
Reviewed-by: Krzysztof Karas <[email protected]>
--
Best Regards,
Krzysztof
