> Subject: [PATCH 2/2] drm/i915/display/lt_phy_regs: Add SoC/OS turnaround
> time

Same comment as the first patch drop display, make it ltphy or keep it 
lt_phy_regs that
Is okay either way

> 
> On top the timeouts mentioned in the spec which includes only the PHY
> timeouts include the SoC and the OS turnaround time.

Same here you can mention based on what we increased the time.

With these fixed LGTM,
Reviewed-by: Suraj Kandpal <[email protected]>

> 
> Signed-off-by: Arun R Murthy <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_lt_phy_regs.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h
> b/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h
> index
> 37e46fb9abde4156ebd7ad1eb6cbbc12e7026b23..ff6d7829dbb9c50b2001d07
> 9b435b894faf9659e 100644
> --- a/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_lt_phy_regs.h
> @@ -6,12 +6,12 @@
>  #ifndef __INTEL_LT_PHY_REGS_H__
>  #define __INTEL_LT_PHY_REGS_H__
> 
> -#define XE3PLPD_MSGBUS_TIMEOUT_FAST_US       500
> +#define XE3PLPD_MSGBUS_TIMEOUT_FAST_US               500
>  #define XE3PLPD_MACCLK_TURNON_LATENCY_MS     2
> -#define XE3PLPD_MACCLK_TURNOFF_LATENCY_US    1
> +#define XE3PLPD_MACCLK_TURNOFF_LATENCY_US    10
>  #define XE3PLPD_RATE_CALIB_DONE_LATENCY_MS   1
> -#define XE3PLPD_RESET_START_LATENCY_US       10
> -#define XE3PLPD_PWRDN_TO_RDY_LATENCY_US      4
> +#define XE3PLPD_RESET_START_LATENCY_US               10
> +#define XE3PLPD_PWRDN_TO_RDY_LATENCY_US              10
>  #define XE3PLPD_RESET_END_LATENCY_MS         2
> 
>  /* LT Phy MAC Register */
> 
> --
> 2.25.1

Reply via email to