On Monday 17 November 2014 07:59 PM, Daniel Vetter wrote:
On Tue, Nov 18, 2014 at 12:09:54PM +0530, Deepak S wrote:
On Tuesday 18 November 2014 12:07 PM, Deepak S wrote:
With pin specific mutex from previous patch set removed
Oops This comment was for previous patch in the series :( Since i
reviewed the patch offline, comments got mixed :)
Please forward these comments from the private discussion to the mailing
list. Review isn't just about code correctness, but about communication -
yes, I (and domain experts) actually read all this stuff that floats
around and will jump into the discussion if there's something important or
tricky being discussed.
Second reason for public review is that the important part about the r-b
tag isn't that review happened, but by whom. So this is all about
reputation building and playing to people's various strenght. And if you
do review in private nothing of that can happen, which makes the review a
lot less useful. So let's extract the most value from all that engineering
time we invest into reviewing and _always_ do the review in public.
Thanks, Daniel
Thanks Daniel. I will make sure to add the comments to mail list :)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
