On Mon, Jan 26, 2015 at 06:03:05PM +0200, Mika Kuoppala wrote: > Now when we declare gpu errors only through our own dedicated > hangcheck workqueue there is no need to have a separate workqueue > for handling the resetting and waking up the clients as the deadlock > concerns are no more. > > The only exception is i915_debugfs::i915_set_wedged, which triggers > error handling through process context. However as this is only used through > test harness it is responsibility for test harness not to introduce hangs > through both debug interface and through hangcheck mechanism at the same time. > > Remove gpu_error.work and let the hangcheck work do the tasks it used to. > > Signed-off-by: Mika Kuoppala <mika.kuopp...@intel.com>
For our own sanity, we need to stick some form of that comment in i915_set_wedged(), so that when we do inevitably blow up, we can laugh at ourselves. Otherwise, lgtm. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
