On Mon, Apr 27, 2015 at 01:41:15PM +0100, Chris Wilson wrote: > Synchronising to an object active on the same ring is a no-op, for the > benefit of execbuffer scheduler. However, for CS flips this means that > we can forgo checking whether the last write request of the object is > actually queued and more importantly whether the cache flush for the > write was emitted. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Nice catch. Hopefully this all goes soon away once we preallocate request. Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 4334e59bf0aa..e3399af8e0cd 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -10898,6 +10898,12 @@ static int intel_crtc_page_flip(struct drm_crtc > *crtc, > i915_gem_request_assign(&work->flip_queued_req, > obj->last_write_req); > } else { > + if (obj->last_write_req) { > + ret = i915_gem_check_olr(obj->last_write_req); > + if (ret) > + goto cleanup_unpin; > + } > + > ret = dev_priv->display.queue_flip(dev, crtc, fb, obj, ring, > page_flip_flags); > if (ret) > -- > 2.1.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx