Op 07-07-15 om 12:28 schreef Daniel Vetter: > On Tue, Jul 07, 2015 at 09:08:20AM +0200, Maarten Lankhorst wrote: >> Perform a full readout of the state by making sure the mode is set >> up correctly atomically. >> >> Also there was a small memory leak by doing the memset, fix this >> by calling __drm_atomic_helper_crtc_destroy_state first. >> >> Changes since v1: >> - Moved after reworking primary plane and updating mode members. >> - Force a modeset calculation by changing mode->type from what the >> final mode will be. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > tbh I don't really like mode_from_pipe_config since it goes in reverse. > With the adjust mode of config_compare we can compare different final hw > states and make a call whether they match enough for modeset avoidance or > not. mode_from_pipe_config otoh is a lie on panels where we can do > upscaling, hence I'd like to remove it to avoid confusion. What do you want the initial mode to be then?
You need to fill in some mode to satisfy drm_atomic_crtc_check. ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
