On 7/27/2015 2:58 PM, Daniel Vetter wrote:
On Sun, Jul 26, 2015 at 02:07:10PM +0530, Uma Shankar wrote:
From: Shashank Sharma <shashank.sha...@intel.com>

This patch adds two new functions:
- disable_dsi_pll.
   BXT DSI disable sequence and registers are
   different from previous platforms.
- intel_disable_dsi_pll
   wrapper function to re-use the same code for
   multiple platforms. It checks platform type and
   calls appropriate core pll disable function.

v2: Fixed Jani's review comments.

Signed-off-by: Shashank Sharma <shashank.sha...@intel.com>
Signed-off-by: Uma Shankar <uma.shan...@intel.com>
---
  drivers/gpu/drm/i915/intel_dsi.c     |    2 +-
  drivers/gpu/drm/i915/intel_dsi.h     |    2 +-
  drivers/gpu/drm/i915/intel_dsi_pll.c |   32 +++++++++++++++++++++++++++++++-
  3 files changed, 33 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index e201c0f..544166f 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -548,7 +548,7 @@ static void intel_dsi_clear_device_ready(struct 
intel_encoder *encoder)
                usleep_range(2000, 2500);
        }
- vlv_disable_dsi_pll(encoder);
+       intel_disable_dsi_pll(encoder);
  }
extern void intel_enable_dsi_pll(struct intel_encoder *encoder);
-extern void vlv_disable_dsi_pll(struct intel_encoder *encoder);
+extern void intel_disable_dsi_pll(struct intel_encoder *encoder);
Kerneldoc for the entire dsi subsystem would be awesome ... are you
working on that too?
-Daniel
Hi Daniel,
Yes that would be really good document to have. Currently not working on that, but will take this up and create a documentation for DSI subsystem along with generic mipi sequence parsing from VBT and backlight control.

Regards,
Uma Shankar
-void vlv_disable_dsi_pll(struct intel_encoder *encoder)
+static void vlv_disable_dsi_pll(struct intel_encoder *encoder)
  {
        struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
        u32 tmp;
@@ -293,6 +293,26 @@ void vlv_disable_dsi_pll(struct intel_encoder *encoder)
        mutex_unlock(&dev_priv->sb_lock);
  }

1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to