On Mon, 2015-08-24 at 14:04 +0000, Zanoni, Paulo R wrote: > Em Qui, 2015-08-20 às 17:55 -0700, Rodrigo Vivi escreveu: > > This is wrong since my commit (89251b17). The intention of that > > commit was to remove this one here that is also wrong anyway, > > but it was forgotten. > > You mentioned the current code is wrong, but it would be really nice > if > you could describe why it is wrong and what are the implications of > it > being wrong. Was this causing some specific problem or was it just > found by code inspection? In case it was found just by code > inspection, > you could try to elaborate on the possible problems brought by the > bad > commit.
nothing critical, by wrong I meant "& ~DP_PSR_MAIN_LINK_ACTIVE" doesn't do anything at all.... I don't remember if when I added I intended to be informative or I removed the val read from dpdc and forgot to remove this part... > > A more elaborate description helps not only the reviewers, but also > the > possible backporters and even helps us judging whether it should be > merged by Daniel or Jani. > > Anyway, as far as I see the patch looks correct, so if you could > provide another paragraph for Daniel to amend on the commit message: > Reviewed-by: Paulo Zanoni <paulo.r.zan...@intel.com> Thanks > > > > > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > > --- > > drivers/gpu/drm/i915/intel_psr.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_psr.c > > b/drivers/gpu/drm/i915/intel_psr.c > > index a04b4dc..51f0514 100644 > > --- a/drivers/gpu/drm/i915/intel_psr.c > > +++ b/drivers/gpu/drm/i915/intel_psr.c > > @@ -170,9 +170,6 @@ static void hsw_psr_enable_sink(struct intel_dp > > *intel_dp) > > > > aux_clock_divider = intel_dp > > ->get_aux_clock_divider(intel_dp, 0); > > > > - drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, > > - DP_PSR_ENABLE & > > ~DP_PSR_MAIN_LINK_ACTIVE); > > - > > /* Enable AUX frame sync at sink */ > > if (dev_priv->psr.aux_frame_sync) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
