On Mon, Aug 24, 2015 at 02:42:50PM +0200, Patrik Jakobsson wrote: > First batch of drm / kms ioctls.
Several comments in addition to issues similar to 4/5 patch.
> +static int drm_mode_rm_fb(struct tcb *tcp, const unsigned int code, long arg)
> +{
> + unsigned int handle;
> +
> +
> + if (entering(tcp)) {
> + if (umove(tcp, arg, &handle))
> + return RVAL_DECODED;
> +
> + tprintf(", %u", handle);
> + }
> +
> + return RVAL_DECODED | 1;
> +}
Use printnum_int instead:
tprints(", ");
printnum_int(tcp, arg, "%u");
return RVAL_DECODED | 1;
> +static int drm_mode_create_dumb(struct tcb *tcp, const unsigned int code,
> long arg)
> +{
> + struct drm_mode_create_dumb dumb;
> +
> + if (umove(tcp, arg, &dumb))
> + return RVAL_DECODED;
> +
> + if (entering(tcp)) {
> + tprintf(", {width=%u, height=%u, bpp=%u, flags=0x%x",
> + dumb.width, dumb.height, dumb.bpp, dumb.flags);
> + } else if (exiting(tcp)) {
> + tprintf(", handle=%u, pitch=%u, size=%Lu}", dumb.handle,
> + dumb.pitch, dumb.size);
> + }
> +
> + return RVAL_DECODED | 1;
> +}
This generates a warning (which turns into an error with
--enable-gcc-Werror) on x86_64 when using kernel drm headers:
drm.c: In function 'drm_mode_create_dumb':
drm.c:521:11: error: format '%Lu' expects argument of type 'long long unsigned
int', but argument 4 has type 'uint64_t {aka long unsigned int}'
[-Werror=format=]
> @@ -112,6 +577,84 @@ int drm_ioctl(struct tcb *tcp, const unsigned int code,
> long arg)
> if (drm_is_priv(tcp->u_arg[1])) {
> if (verbose(tcp) && drm_is_driver(tcp, "i915"))
> ret = drm_i915_ioctl(tcp, code, arg);
> + } else {
> + switch (code) {
> + case DRM_IOCTL_VERSION:
> + ret = drm_version(tcp, code, arg);
> + break;
Looks like the return code can be forwarded without further delays.
--
ldv
pgpdCzNMLBccW.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
