On Mon, Nov 30, 2015 at 01:32:16PM +0000, Tvrtko Ursulin wrote:
>
> On 30/11/15 12:30, Chris Wilson wrote:
> >On Mon, Nov 30, 2015 at 12:05:50PM +0000, Tvrtko Ursulin wrote:
> >>>+ while (!kthread_should_stop()) {
> >>>+ unsigned reset_counter = i915_reset_counter(&i915->gpu_error);
> >>>+ unsigned long timeout_jiffies;
> >>>+ bool idling = false;
> >>>+
> >>>+ /* On every tick, walk the seqno-ordered list of requests
> >>>+ * and for each retired request wakeup its clients. If we
> >>>+ * find an unfinished request, go back to sleep.
> >>>+ */
> >>
> >>s/tick/loop/ ?
> >s/tick/iteration/ I'm sticking with tick
>
> Tick makes me tick of a scheduler tick so to me it is the worst of
> the three. Iteration sounds really good. Whether that will be a
> tick/jiffie/orsomething is definite a bit lower in the code.
wakeup? Going with "On every wakeup". The duplication of wakeup then
emphasises the extra wakeup we introduction into i915_wait_request.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
