On 18.03.2016 16:02, Rodrigo Vivi wrote:
The following piglit commit adds one option to overwrite files: commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db Author: Dylan Baker <[email protected]> Date: Mon Feb 1 15:08:23 2016 -0800 framework/programs/run.py: Add option for overwriting files So our run-script.sh test that creates the directory before executing the tests were failing with: "Fatal Error: Cannot overwrite existing folder w/o the -o /--overwrite option being sent" I believe it took a while to notice that because many of us never upgrade the piglit. But also the risk with this patch is to have an environment with the old piglit so the result will be: piglit: error: unrecognized arguments: --overwrite So, let's start the discussion and also provide the patch that allows some people with new version to get it running. Cc: Dylan Baker <[email protected]> Cc: Alexandra Yates <[email protected]> Signed-off-by: Rodrigo Vivi <[email protected]> --- scripts/run-tests.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh index 99e6124..b1abeab 100755 --- a/scripts/run-tests.sh +++ b/scripts/run-tests.sh @@ -124,8 +124,7 @@ fi if [ "x$RESUME" != "x" ]; then sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY else - mkdir -p "$RESULTS" - sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER + sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run --overwrite igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER fi if [ "$SUMMARY" == "html" ]; then
I've sent something similar some time ago: https://patchwork.freedesktop.org/patch/76050/ Gabriel. _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
