On Thu, Jul 21, 2016 at 06:39:38PM +0100, Dave Gordon wrote: > The exit path in intel_overlay_put_image_ioctl() first unlocks the > struct_mutex, then drops its reference to 'new_bo' by calling > i915_gem_object_put(). As it isn't holding the mutex at this point, > this should be i915_gem_object_put_unlocked(). > > This was previously correct but got splatted in the recent > s/drm_gem_object_unreference/i915_gem_object_put/ > where the _unlocked suffix was lost in this one case. > > v2: don't bother fixing whitespace glitch [Chris Wilson] > Chris can do it next time he touches gem_evict.c ;)
He plans to, it is drm/i915: Release vma when the handle is closed, where we don't need to touch the obj in that loop any more. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
