On Wed, 14 Sep 2016, "Zanoni, Paulo R" <paulo.r.zan...@intel.com> wrote: > Em Qua, 2016-09-14 às 12:34 +0300, Jani Nikula escreveu: >> On Wed, 14 Sep 2016, Paulo Zanoni <paulo.r.zan...@intel.com> wrote: >> > >> > Hi >> > >> > Here's the series with the reviews implemented. There's a new >> > patch, >> > based on the additional issue spotted by Lyude. >> >> There's a bunch of cc: stable patches mixed with non cc: stable >> patches >> in the series. Do the cc: stable fixes work and backport cleanly >> without >> the the other non cc: stable patches? If not, can you arrange the >> series >> to not depend on the other patches? > > Yeah, my bad. I was just pasting the output of "dim fixes" without > considering this aspect. I think the best thing is probably to backport > everything to stable and hope it works, considering the current > complaints we're seeing about screen flickering on SKL. Agree?
The short answer, agreed. This probably needs actual backporting, i.e. doesn't cherry-pick cleanly, and it could probably use some testing too. What happens if the stable folks manage to cherry-pick some but not all the patches cleanly? BR, Jani. > > I suppose I don't need to resend the series just for these new tags. > I'll add them when it's time to merge. > >> >> BR, >> Jani. >> >> >> > >> > >> > Thanks for all the reviews, >> > Paulo >> > >> > Paulo Zanoni (9): >> > drm/i915: SAGV is not SKL-only, so rename a few things >> > drm/i915: introduce intel_has_sagv() >> > drm/i915/kbl: KBL also needs to run the SAGV code >> > drm/i915/gen9: fix the WaWmMemoryReadLatency implementation >> > drm/i915/gen9: minimum scanlines for Y tile is not always 4 >> > drm/i915/gen9: fix plane_blocks_per_line on watermarks >> > calculations >> > drm/i915/gen9: fix the watermark res_blocks value >> > drm/i915/gen9: implement missing case for SKL watermarks >> > calculation >> > drm/i915/gen9: fail the modeset instead of WARNing on unsuported >> > config >> > >> > drivers/gpu/drm/i915/i915_drv.h | 10 +- >> > drivers/gpu/drm/i915/intel_display.c | 9 +- >> > drivers/gpu/drm/i915/intel_drv.h | 6 +- >> > drivers/gpu/drm/i915/intel_pm.c | 186 ++++++++++++++++++++--- >> > ------------ >> > 4 files changed, 118 insertions(+), 93 deletions(-) >> -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
