> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jesse > Brandeburg > Sent: Wednesday, December 6, 2023 6:31 AM > To: [email protected] > Cc: Kitszel, Przemyslaw <[email protected]>; Brandeburg, Jesse > <[email protected]>; Lobakin, Aleksander > <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: [Intel-wired-lan] [PATCH iwl-next v2 14/15] ice: cleanup > inconsistent code > > It was found while doing further testing of the previous commit > fbf32a9bab91 ("ice: field get conversion") that one of the FIELD_GET > conversions should really be a FIELD_PREP. The previous code was styled > as a match to the FIELD_GET conversion, which always worked because the > shift value was 0. The code makes way more sense as a FIELD_PREP and > was in fact the only FIELD_GET with two constant arguments in this > series. > > Didn't squash this patch to make it easier to call out the > (non-impactful) bug. > > Signed-off-by: Jesse Brandeburg <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +- > drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
