> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Grzegorz Nitka > Sent: Thursday, December 7, 2023 12:59 AM > To: [email protected] > Cc: [email protected]; Anirudh Venkataramanan > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: Add helper function > ice_is_generic_mac > > E800 series devices have a couple of quirks: > 1. Sideband control queues are not supported > 2. The registers that the driver needs to program for the "Precision > Time Protocol (PTP)" feature are different for E800 series devices > compared to other devices supported by this driver. > > Both these require conditional logic based on the underlying device we > are dealing with. > > The function ice_is_sbq_supported added by commit 8f5ee3c477a8 > ("ice: add support for sideband messages") addresses (1). > The same function can be used to address (2) as well > but this just looks weird readability wise in cases that have nothing > to do with sideband control queues: > > if (ice_is_sbq_supported(hw)) > /* program register A */ > else > /* program register B */ > > For these cases, the function ice_is_generic_mac introduced by this > patch communicates the idea/intention better. Also rework > ice_is_sbq_supported to use this new function. > As side-band queue is supported for E825C devices, it's mac_type is > considered as generic mac_type. > > Co-developed-by: Anirudh Venkataramanan <[email protected]> > Signed-off-by: Anirudh Venkataramanan <[email protected]> > Signed-off-by: Grzegorz Nitka <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_common.c | 12 ++++++++++++ > drivers/net/ethernet/intel/ice/ice_common.h | 1 + > drivers/net/ethernet/intel/ice/ice_controlq.c | 2 +- > drivers/net/ethernet/intel/ice/ice_main.c | 6 ++++-- > drivers/net/ethernet/intel/ice/ice_type.h | 1 + > 5 files changed, 19 insertions(+), 3 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
