Dear Jesse,
Thank you for your patch.
Am 05.03.24 um 00:08 schrieb Jesse Brandeburg:
The ice driver would previously panic during suspend. This is caused
from the driver *only* calling the ice_vsi_free_q_vectors() function by
itself, when it is suspending. Since commit b3e7b3a6ee92 ("ice: prevent
NULL pointer deref during reload") the driver has zeroed out
num_q_vectors, and only restored it in ice_vsi_cfg_def().
This further causes the ice_rebuild() function to allocate a zero length
buffer, after which num_q_vectors is updated, and then the new value of
num_q_vectors is used to index into the zero length buffer, which
corrupts memory.
[…]
For the commit message summary I suggest to be more specific. Maybe:
ice: Fix memory corruption with suspend and rebuild
ice: Avoid 0-length buffer to fix memory corruption with suspend/rebuild
Reviewed-by: Paul Menzel <[email protected]>
Kind regards,
Paul
