> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Dave > Ertman > Sent: Friday, May 24, 2024 2:34 AM > To: [email protected] > Cc: Kitszel, Przemyslaw <[email protected]>; Czapnik, Lukasz > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice: check for unregistering > correct number of devlink params > > On module load, the ice driver checks for the lack of a specific PF > capability to determine if it should reduce the number of devlink params to > register. One situation when this test returns true is when the driver loads > in safe mode. The same check is not present on the unload path when devlink > params are unregistered. This results in the driver triggering a WARN_ON in > the kernel devlink code. > > The current check and code path uses a reduction in the number of elements > reported in the list of params. This is fragile and not good for future > maintaining. > > Change the parameters to be held in two lists, one always registered and one > dependent on the check. > > Add a symmetrical check in the unload path so that the correct parameters are > unregistered as well. > > Fixes: 109eb2917284 ("ice: Add tx_scheduling_layers devlink param") > CC: Lukasz Czapnik <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Dave Ertman <[email protected]> > > --- > Changes in v2: break params into two list clean up variable usage > --- > .../net/ethernet/intel/ice/devlink/devlink.c | 31 +++++++++++++------ > 1 file changed, 22 insertions(+), 9 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
