> This patch adds support for firmware update to the in-tree igb driver and it > is actually a port from the out-of-tree igb driver. > In-band firmware update is one of the essential system maintenance tasks. To > simplify this task, the Intel online firmware update …
Please improve such a change description also according to word wrapping because of more desirable text line lengths. … > +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c > @@ -724,128 +724,282 @@ static void igb_get_regs(struct net_device *netdev, > regs_buff[739] = rd32(E1000_I210_RR2DCDELAY); > } > > -static int igb_get_eeprom_len(struct net_device *netdev) > -{ > - struct igb_adapter *adapter = netdev_priv(netdev); > - return adapter->hw.nvm.word_size * 2; > +static u8 igb_nvmupd_get_module(u32 val) > +{ > + return (u8)(val & E1000_NVMUPD_MOD_PNT_MASK); > +} … Would you like to reconsider the indentation once more for your change approach? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.10-rc2#n18 Regards, Markus