From: Alexander Lobakin <aleksander.loba...@intel.com> Date: Wed, 12 Jun 2024 11:09:10 +0200
> From: Maciej Fijalkowski <maciej.fijalkow...@intel.com> > Date: Tue, 11 Jun 2024 16:21:27 +0200 [...] >>>> diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c >>>> b/drivers/net/ethernet/intel/ice/ice_xsk.c >>>> index 2015f66b0cf9..1bd4b054dd80 100644 >>>> --- a/drivers/net/ethernet/intel/ice/ice_xsk.c >>>> +++ b/drivers/net/ethernet/intel/ice/ice_xsk.c >>>> @@ -1048,6 +1048,10 @@ bool ice_xmit_zc(struct ice_tx_ring *xdp_ring) >>>> >>>> ice_clean_xdp_irq_zc(xdp_ring); >>>> >>>> + if (!netif_carrier_ok(xdp_ring->vsi->netdev) || >>>> + !netif_running(xdp_ring->vsi->netdev)) Oh BTW, I noticed some time ago that netif_running() is less precise than checking for %IFF_UP. For example, in this piece (main netdev ifup function)[0], netif_running() will start returning true *before* driver's .ndo_open() is called, but %IFF_UP will be set only after .ndo_open() is done (with no issues). That means, I'd check for %IFF_UP honestly (maybe even before checking the carrier). [0] https://elixir.bootlin.com/linux/v6.10-rc3/source/net/core/dev.c#L1466 Thanks, Olek
