> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of > Marcin Szycik > Sent: Friday, June 14, 2024 4:08 PM > To: intel-wired-...@lists.osuosl.org > Cc: Gardocki, PiotrX <piotrx.gardo...@intel.com>; net...@vger.kernel.org; > Marcin Szycik <marcin.szy...@linux.intel.com>; Zaki, Ahmed > <ahmed.z...@intel.com>; Kitszel, Przemyslaw <przemyslaw.kits...@intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset and > removal for AQ shutdown > > From: Piotr Gardocki <piotrx.gardo...@intel.com> > > Admin queue command for shutdown AQ contains a flag to indicate driver > unload. However, the flag is always set in the driver, even for resets. It > can cause the firmware to consider driver as unloaded once the PF reset is > triggered on all ports of device, which could lead to unexpected results. > > Add an additional function parameter to functions that shutdown AQ, > indicating whether the driver is actually unloading. > > Reviewed-by: Ahmed Zaki <ahmed.z...@intel.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > Signed-off-by: Piotr Gardocki <piotrx.gardo...@intel.com> > Signed-off-by: Marcin Szycik <marcin.szy...@linux.intel.com> > --- > drivers/net/ethernet/intel/ice/ice_common.h | 2 +- > drivers/net/ethernet/intel/ice/ice_controlq.c | 19 +++++++++++-------- > drivers/net/ethernet/intel/ice/ice_main.c | 6 +++--- > 3 files changed, 15 insertions(+), 12 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A Contingent worker at Intel)
