On 6/18/24 16:21, Loktionov, Aleksandr wrote:
-----Original Message-----
From: Kitszel, Przemyslaw <przemyslaw.kits...@intel.com>
Sent: Tuesday, June 18, 2024 3:50 PM
To: Loktionov, Aleksandr <aleksandr.loktio...@intel.com>; Nguyen,
Anthony L <anthony.l.ngu...@intel.com>
Cc: net...@vger.kernel.org; Kang, Kelvin <kelvin.k...@intel.com>;
Kubalewski, Arkadiusz <arkadiusz.kubalew...@intel.com>; intel-wired-
l...@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v4] i40e: fix hot issue
NVM content is corrupted after nvmupdate
On 6/18/24 15:21, Aleksandr Loktionov wrote:
The bug affects users only at the time when they try to update NVM,
and only F/W versions that generate errors while nvmupdate. For
example, X710DA2 with 0x8000ECB7 F/W is affected, but there are
probably more...
Command for reproduction is just NVM update:
./nvmupdate64
nvmupdate64 is not an upstream tool, but it's fine to mention it here,
as we don't have a better alternative for i40e as of now
In the log instead of:
i40e_nvmupd_exec_aq err I40E_ERR_ADMIN_QUEUE_ERROR aq_err
I40E_AQ_RC_ENOMEM)
appears:
i40e_nvmupd_exec_aq err -EIO aq_err I40E_AQ_RC_ENOMEM
But the problematic code did silently convert EIO into EAGAIN which
forced nvmupdate to ignore EAGAIN error and retry the same operation
until timeout.
That's why NVM update takes 20+ minutes to finish with the fail in
the end.
this paragraph tells more about nvmupdate tool problems that the
driver
What is your proposal for it exactly?
Perhaps this could be summarized as:
This driver issue leads to nvmupdate needlessly retrying for over 20
minutes to only fail at the end. It is even worse that NVM content
could be broken after the broken update.
But I'm fine with it as is too.
After commit 230f3d53a547 ("i40e: remove i40e_status"), which should
only replace F/W specific error codes with Linux kernel generic,
all EIO errors
suddenly started to be converted into EAGAIN
all or just this one that you are fixing here?
All error codes from FW which exactly I'm fixing of course.
fine
which leads nvmupdate to retry
until it timeouts and sometimes fails after more than 20 minutes in
the middle of NVM update, so NVM becomes corrupted.
Remove wrong EIO to EGAIN conversion and pass all errors as is.
Fixes: 230f3d53a547 ("i40e: remove i40e_status")
That is a proper tag, and the description makes it clear that we want
the patch finally applied, thank you for the efforts to make it well
described.
Co-developed-by: Kelvin Kang <kelvin.k...@intel.com>
Signed-off-by: Kelvin Kang <kelvin.k...@intel.com>
this 2 line removal was indeed developed by two of you?
As written above, yes of course.
fine
Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalew...@intel.com>
Signed-off-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com>
---
v3->v4 commit message update
Please fix the subject line too, it's what will be the most frequently
read part of your work, and with stay in git for decades. You could
use:
i40e: fix wrong error code replacement
This patch fixes urgent/hot issue with NVM update, which is stated in the
title. Wrong error conversion code could lead to different severity issues.
From my point it's better to mention in the title the serious problem which
users meet/see, am I wrong?
I believe so, please send v5 with a new title, like:
i40e: prevent needless retries of NVM update
(no "hot issue", this is as hot as the more severe half of i40e bugs).
I know that you like to have "fix" in the title, but this is not
required for the kernel, as the same info is assumed from Fixes: tag.
If you insist, then:
i40e: fix: prevent needless retries of NVM update
By trying to start the sentence from "fix", you dragged yourself into
this convoluted need for explaining yourself ;)
and add link in changelog section:
v4:
https://lore.kernel.org/netdev/20240618132111.3193963-1-
aleksandr.loktio...@intel.com/T/#u
v2->v3 commit messege typos
v1->v2 commit message update
---
drivers/net/ethernet/intel/i40e/i40e_adminq.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.h
b/drivers/net/ethernet/intel/i40e/i40e_adminq.h
index ee86d2c..55b5bb8 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.h
@@ -109,10 +109,6 @@ static inline int i40e_aq_rc_to_posix(int
aq_ret, int aq_rc)
-EFBIG, /* I40E_AQ_RC_EFBIG */
};
- /* aq_rc is invalid if AQ timed out */
- if (aq_ret == -EIO)
- return -EAGAIN;
-
if (!((u32)aq_rc < (sizeof(aq_to_posix) /
sizeof((aq_to_posix)[0]))))
return -ERANGE;
