On Fri, Jun 28, 2024 at 03:56:55PM +0200, Przemek Kitszel wrote: > On 6/28/24 14:44, Simon Horman wrote: > > On Tue, Jun 18, 2024 at 04:11:56PM +0200, Marcin Szycik wrote:
... > > I appreciate the detailed description above, it is very helpful. > > After a number of readings of this patch - it is complex - > > I was unable to find anything wrong. And I do like both the simplification > > and better hw utilisation that this patch (set) brings. > > > > So from that perspective: > > > > Reviewed-by: Simon Horman <ho...@kernel.org> > > > > I would say, however, that it might have been easier to review > > if somehow this patch was broken up into smaller pieces. > > I appreciate that, in a sense, that is what the other patches > > of this series do. But nonetheless... it is complex. > > > > ... > > all of the "bugs" that I have internally found for this patch were > addressed by commit msg or comment changes ;) > what about you reviewing also patch 7 from v3 of this series? Right, sorry about accidently reviewing an old version of the patchset. I will look at 7 from v3.
