On Thu, Jun 27, 2024 at 05:09:31PM +0200, Karol Kolacinski wrote: > From: Sergey Temerkhanov <sergey.temerkha...@intel.com> > > Implement 1PPS signal enabling/disabling in CGU. The amplitude is > always the maximum in this implementation > > Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalew...@intel.com> > Signed-off-by: Sergey Temerkhanov <sergey.temerkha...@intel.com> > Co-developed-by: Karol Kolacinski <karol.kolacin...@intel.com> > Signed-off-by: Karol Kolacinski <karol.kolacin...@intel.com>
... > diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c > b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c > index 07ecf2a86742..fa7cf8453b88 100644 > --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c > +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c > @@ -661,6 +661,27 @@ static int ice_cfg_cgu_pll_e825c(struct ice_hw *hw, > return 0; > } > > +#define ICE_ONE_PPS_OUT_AMP_MAX 3 > + > +/** > + * ice_cgu_ena_pps_out - Enable/disable 1PPS output > + * @hw: pointer to the HW struct > + * @ena: Enable/disable 1PPS output Please include a "Returns: " or "Return: " section in the kernel doc for functions that have a return value. NIPA has recently got more picky about this. Flagged by kernel-doc -none --Warn > + */ > +int ice_cgu_ena_pps_out(struct ice_hw *hw, bool ena) > +{ > + union nac_cgu_dword9 dw9; > + int err; > + > + err = ice_read_cgu_reg_e82x(hw, NAC_CGU_DWORD9, &dw9.val); > + if (err) > + return err; > + > + dw9.one_pps_out_en = ena; > + dw9.one_pps_out_amp = ena * ICE_ONE_PPS_OUT_AMP_MAX; > + return ice_write_cgu_reg_e82x(hw, NAC_CGU_DWORD9, dw9.val); > +} > + > /** > * ice_cfg_cgu_pll_dis_sticky_bits_e82x - disable TS PLL sticky bits > * @hw: pointer to the HW struct ...