> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Wojciech Drewek
> Sent: Friday, September 27, 2024 6:08 PM
> To: net...@vger.kernel.org
> Cc: Nguyen, Anthony L <anthony.l.ngu...@intel.com>;
> marcin.szy...@linux.intel.com; intel-wired-...@lists.osuosl.org;
> ho...@kernel.org; michal.swiatkow...@linux.intel.com
> Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice: Flush FDB entries before
> reset
>
> Triggering the reset while in switchdev mode causes errors[1]. Rules are
> already removed by this time because switch content is flushed in case of the
> reset.
> This means that rules were deleted from HW but SW still thinks they exist so
> when we get SWITCHDEV_FDB_DEL_TO_DEVICE notification we try to delete
> not existing rule.
>
> We can avoid these errors by clearing the rules early in the reset flow before
> they are removed from HW.
> Switchdev API will get notified that the rule was removed so we won't get
> SWITCHDEV_FDB_DEL_TO_DEVICE notification.
> Remove unnecessary ice_clear_sw_switch_recipes.
>
> [1]
> ice 0000:01:00.0: Failed to delete FDB forward rule, err: -2 ice 0000:01:00.0:
> Failed to delete FDB guard rule, err: -2
>
> Fixes: 7c945a1a8e5f ("ice: Switchdev FDB events support")
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlo...@intel.com>
> Signed-off-by: Wojciech Drewek <wojciech.dre...@intel.com>
> ---
> v2: extend commit msg, add NULL pointer check
> ---
> .../net/ethernet/intel/ice/ice_eswitch_br.c | 5 +++-
> .../net/ethernet/intel/ice/ice_eswitch_br.h | 1 +
> drivers/net/ethernet/intel/ice/ice_main.c | 24 +++----------------
> 3 files changed, 8 insertions(+), 22 deletions(-)
>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswa...@intel.com>
