> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Marcin Szycik
> Sent: Tuesday, September 24, 2024 3:34 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Fijalkowski, Maciej <maciej.fijalkow...@intel.com>;
> net...@vger.kernel.org; Polchlopek, Mateusz
> <mateusz.polchlo...@intel.com>; Marcin Szycik
> <marcin.szy...@linux.intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kits...@intel.com>; bcree...@amd.com
> Subject: [Intel-wired-lan] [PATCH iwl-net v3 2/2] ice: Fix netif_is_ice() in
> Safe
> Mode
>
> netif_is_ice() works by checking the pointer to netdev ops. However, it only
> checks for the default ice_netdev_ops, not ice_netdev_safe_mode_ops, so in
> Safe Mode it always returns false, which is unintuitive. While it doesn't look
> like netif_is_ice() is currently being called anywhere in Safe Mode, this
> could
> change and potentially lead to unexpected behaviour.
>
> Fixes: df006dd4b1dc ("ice: Add initial support framework for LAG")
> Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
> Signed-off-by: Marcin Szycik <marcin.szy...@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswa...@intel.com>
