> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Tore > Amundsen > Sent: 15 November 2024 19:48 > To: [email protected] > Cc: [email protected]; [email protected]; Nguyen, Anthony L > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Kitszel, Przemyslaw > <[email protected]>; [email protected] > Subject: [Intel-wired-lan] [PATCH v3 1/1] ixgbe: Correct BASE-BX10 compliance > code > > SFF-8472 (section 5.4 Transceiver Compliance Codes) defines bit 6 as > BASE-BX10. Bit 6 means a value of 0x40 (decimal 64). > > The current value in the source code is 0x64, which appears to be a mix-up of > hex and decimal values. A value of 0x64 (binary 01100100) incorrectly sets > bit 2 (1000BASE-CX) and bit 5 (100BASE-FX) as well. > > Fixes: 1b43e0d20f2d ("ixgbe: Add 1000BASE-BX support") > Signed-off-by: Tore Amundsen <[email protected]> > Reviewed-by: Paul Menzel <[email protected]> > Acked-by: Ernesto Castellotti <[email protected]> > --- > v2: Added Fixes tag as requested by Paul Menzel. > v3: Correct Fixes tag format and add Acked-By. > > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
