On Tue Feb 18 2025, Joe Damato wrote: > On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote: >> This is a follow up for the igb XDP/ZC implementation. The first two >> patches link the IRQs and queues to NAPI instances. This is required to >> bring back the XDP/ZC busy polling support. The last patch removes >> undesired IRQs (injected via igb watchdog) while busy polling with >> napi_defer_hard_irqs and gro_flush_timeout set. >> >> Signed-off-by: Kurt Kanzenbach <[email protected]> >> --- >> Changes in v2: >> - Take RTNL lock in PCI error handlers (Joe) >> - Fix typo in commit message (Gerhard) >> - Use netif_napi_add_config() (Joe) >> - Link to v1: >> https://lore.kernel.org/r/[email protected] > > Thanks for sending a v2.
Thanks for the review.
>
> My comment from the previous series still stands, which simply that
> I have no idea if the maintainers will accept changes using this API
> or prefer to wait until Stanislav's work [1] is completed to remove
> the RTNL requirement from this API altogether.
I'd rather consider patch #2 a bugfix to restore the busy polling with
XDP/ZC. After commit 5ef44b3cb43b ("xsk: Bring back busy polling
support") it is a requirement to implement this API.
The maintainers didn't speak up on v1, so i went along and sent v2.
@Jakub: What's your preference? Would you accept this series or rather
like to wait for Stanislav's work to be finished?
>
> [1]: https://lore.kernel.org/netdev/[email protected]/
>
signature.asc
Description: PGP signature
