From: Paul Menzel <[email protected]> Sent: Friday, February 28, 2025 11:17 AM
>Dear Jedrzej, > > >Thank you for your patch. > >Am 28.02.25 um 09:37 schrieb Jedrzej Jagielski: >> E610's implementation of various ethtool ops is different than >> the ones corresponding to ixgbe legacy products. Therefore create >> separate E610 ethtool_ops struct which will be filled out in the >> forthcoming patches. >> >> Assing adequate ops struct basing on mac type. This step requires > >1. A*dd*ing >2. Maybe even imperative mood: Add. >3. … based on MAC type. Hello Paul that's really unfortunate mistake, i don't know how i could pass it by thank you for pointing it out! :) Regards Jedrek > >> changing a bit the flow of probing by placing ixgbe_set_ethtool_ops >> after mac type is assigned. So move the whole netdev assignment >> block after mac_type is known. This step doesn't have any additional >> impact on probing sequence. >> >> Suggested-by: Aleksandr Loktionov <[email protected]> >> Reviewed-by: Aleksandr Loktionov <[email protected]> >> Signed-off-by: Jedrzej Jagielski <[email protected]> >> ---
