On 2025-04-29 5:52 PM, Maciej Fijalkowski wrote:
Currently ixgbe driver checks periodically in its watchdog subtask if there is anything to be transmitted (consdidering both Tx and XDP rings)
typo: s/consdidering/considering
under state of carrier not being 'ok'. Such event is interpreted as Tx hang and therefore results in interface reset. This is currently problematic for ndo_xdp_xmit() as it is allowed to produce descriptors when interface is going through reset or its carrier is turned off. Furthermore, XDP rings should not really be objects of Tx hang detection. This mechanism is rather a matter of ndo_tx_timeout() being called from dev_watchdog against Tx rings exposed to networking stack. Taking into account issues described above, let us have a two fold fix - do not respect XDP rings in local ixgbe watchdog and do not produce Tx descriptors in ndo_xdp_xmit callback when there is some problem with carrier currently. For now, keep the Tx hang checks in clean Tx irq routine, but adjust it to not execute it for XDP rings.
suggestion: s/adjust it to not execute it/adjust it to not execute Best regards, Dawid
