> -----Original Message----- > From: Nguyen, Anthony L <[email protected]> > Sent: Thursday, May 1, 2025 10:03 AM > To: Keller, Jacob E <[email protected]>; netdev > <[email protected]>; > Intel Wired LAN <[email protected]> > Cc: Kitszel, Przemyslaw <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Olech, Milena <[email protected]>; > Kubiak, Michal <[email protected]>; Kolacinski, Karol > <[email protected]> > Subject: Re: [PATCH v3 01/15] ice: move TSPLL functions to a separate file > > > > On 4/30/2025 3:51 PM, Jacob Keller wrote: > > From: Karol Kolacinski <[email protected]> > > > > Collect TSPLL related functions and definitions and move them to > > a separate file to have all TSPLL functionality in one place. > > I mentioned in one of the earlier versions that this lost/reverted > commit 4c9f13a65426 ("ice: use string choice helpers"), we should > restore that. That will trickle some adjustments into the later patches > as well i.e. use helper over open coding. > > Thanks, > Tony >
Ahh.. Should have spotted that. Will fix in v4 with a rebase on top of the IWL to handle the issues with libie adminq changes as well. > > Move CGU related functions and definitions to ice_common.* > > > > Reviewed-by: Michal Kubiak <[email protected]> > > Reviewed-by: Milena Olech <[email protected]> > > Signed-off-by: Karol Kolacinski <[email protected]> >
