> -----Original Message-----
> From: Nguyen, Anthony L <anthony.l.ngu...@intel.com>
> Sent: Thursday, May 1, 2025 10:03 AM
> To: Keller, Jacob E <jacob.e.kel...@intel.com>; netdev
> <net...@vger.kernel.org>;
> Intel Wired LAN <intel-wired-...@lists.osuosl.org>
> Cc: Kitszel, Przemyslaw <przemyslaw.kits...@intel.com>; Loktionov, Aleksandr
> <aleksandr.loktio...@intel.com>; Olech, Milena <milena.ol...@intel.com>;
> Kubiak, Michal <michal.kub...@intel.com>; Kolacinski, Karol
> <karol.kolacin...@intel.com>
> Subject: Re: [PATCH v3 01/15] ice: move TSPLL functions to a separate file
>
>
>
> On 4/30/2025 3:51 PM, Jacob Keller wrote:
> > From: Karol Kolacinski <karol.kolacin...@intel.com>
> >
> > Collect TSPLL related functions and definitions and move them to
> > a separate file to have all TSPLL functionality in one place.
>
> I mentioned in one of the earlier versions that this lost/reverted
> commit 4c9f13a65426 ("ice: use string choice helpers"), we should
> restore that. That will trickle some adjustments into the later patches
> as well i.e. use helper over open coding.
>
> Thanks,
> Tony
>
Ahh.. Should have spotted that. Will fix in v4 with a rebase on top of the IWL
to handle the issues with libie adminq changes as well.
> > Move CGU related functions and definitions to ice_common.*
> >
> > Reviewed-by: Michal Kubiak <michal.kub...@intel.com>
> > Reviewed-by: Milena Olech <milena.ol...@intel.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacin...@intel.com>
>
