Unlike previous internal idpf ctlq implementation, idpf calls the default
message handler for all received messages that do not have a matching xn
transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error
messages printing garbage, because the parsing expected a valid event
message, but got e.g. a delayed response for a timed-out transaction.
The information about timed-out transactions and otherwise unhandleable
messages can still be valuable for developers, so print the information
with dynamic debug and exit the function, so the following functions can
parse valid events in peace.
Reviewed-by: Michal Kubiak <michal.kub...@intel.com>
Signed-off-by: Larysa Zaremba <larysa.zare...@intel.com>
---
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
index 03cb42bffe60..076c68fcb446 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
@@ -82,6 +82,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx,
u32 event;
adapter = container_of(ctx, struct idpf_adapter, ctlq_ctx);
+ if (ctlq_msg->chnl_opcode != VIRTCHNL2_OP_EVENT) {
+ dev_dbg(&adapter->pdev->dev,
+ "Unhandled message with opcode %u from CP\n",
+ ctlq_msg->chnl_opcode);
+ goto free_rx_buf;
+ }
+
if (payload_size < sizeof(*v2e)) {
dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive
valid payload for event msg (op %d len %d)\n",
ctlq_msg->chnl_opcode,
--
2.47.0
