> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Michal Swiatkowski > Sent: 25 April 2025 11:38 > To: [email protected] > Cc: [email protected]; Lobakin, Aleksander > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Kwapulinski, Piotr > <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Jagielski, Jedrzej > <[email protected]>; Zaremba, Larysa <[email protected]>; > Nguyen, Anthony L <[email protected]> > Subject: [Intel-wired-lan] [iwl-next v3 1/8] ice, libie: move generic adminq > descriptors to lib > > The descriptor structure is the same in ice, ixgbe and i40e. Move it to common libie header to use it across different driver. > > Leave device specific adminq commands in separate folders. This lead to a change that need to be done in filling/getting descriptor: > - previous: struct specific_desc *cmd; cmd = &desc.params.specific_desc; > - now: struct specific_desc *cmd; cmd = libie_aq_raw(&desc); > > Do this changes across the driver to allow clean build. The casting only have to be done in case of specific descriptors, for generic one union can still be used. > > Changes beside code moving: > - change ICE_ prefix to LIBIE_ prefix (ice_ and libie_ too) > - remove shift variables not otherwise needed (in libie_aq_flags) > - fill/get descriptor data based on desc.params.raw whenever the descriptor isn't defined in libie > - move defines from the libie_aq_sth structure outside > - add libie_aq_raw helper and use it instead of explicit casting > > Reviewed by: Przemek Kitszel <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Michal Swiatkowski <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice.h | 2 +- > .../net/ethernet/intel/ice/ice_adminq_cmd.h | 270 +----------- > drivers/net/ethernet/intel/ice/ice_common.h | 6 +- > drivers/net/ethernet/intel/ice/ice_controlq.h | 8 +- > include/linux/net/intel/libie/adminq.h | 272 ++++++++++++ > .../net/ethernet/intel/ice/devlink/health.c | 4 +- > drivers/net/ethernet/intel/ice/ice_common.c | 390 +++++++++--------- > drivers/net/ethernet/intel/ice/ice_controlq.c | 53 +-- > drivers/net/ethernet/intel/ice/ice_dcb.c | 36 +- > drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 2 +- > drivers/net/ethernet/intel/ice/ice_ddp.c | 47 +-- > .../net/ethernet/intel/ice/ice_fw_update.c | 24 +- > drivers/net/ethernet/intel/ice/ice_fwlog.c | 16 +- > drivers/net/ethernet/intel/ice/ice_lag.c | 4 +- > drivers/net/ethernet/intel/ice/ice_lib.c | 6 +- > drivers/net/ethernet/intel/ice/ice_main.c | 34 +- > drivers/net/ethernet/intel/ice/ice_nvm.c | 38 +- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 20 +- > drivers/net/ethernet/intel/ice/ice_sched.c | 18 +- > drivers/net/ethernet/intel/ice/ice_sriov.c | 4 +- > drivers/net/ethernet/intel/ice/ice_switch.c | 55 +-- > drivers/net/ethernet/intel/ice/ice_vf_mbx.c | 6 +- > drivers/net/ethernet/intel/ice/ice_virtchnl.c | 2 +- > .../net/ethernet/intel/ice/ice_vlan_mode.c | 6 +- > 24 files changed, 673 insertions(+), 650 deletions(-) > create mode 100644 include/linux/net/intel/libie/adminq.h >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
