Dear Michal,
Thank you for the patch. Am 24.06.25 um 11:26 schrieb Michal Swiatkowski:
pf->ice_debugfs_pf_fwlog should be check for an error here.
be check*ed*
Fixes: 96a9a9341cda ("ice: configure FW logging") Reviewed-by: Przemek Kitszel <[email protected]> Signed-off-by: Michal Swiatkowski <[email protected]> --- drivers/net/ethernet/intel/ice/ice_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c index 9fc0fd95a13d..cb71eca6a85b 100644 --- a/drivers/net/ethernet/intel/ice/ice_debugfs.c +++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c @@ -606,7 +606,7 @@ void ice_debugfs_fwlog_init(struct ice_pf *pf)pf->ice_debugfs_pf_fwlog = debugfs_create_dir("fwlog",pf->ice_debugfs_pf); - if (IS_ERR(pf->ice_debugfs_pf)) + if (IS_ERR(pf->ice_debugfs_pf_fwlog)) goto err_create_module_files;fw_modules_dir = debugfs_create_dir("modules",
With the above fixed: Reviewed-by: Paul Menzel <[email protected]> Kind regards, Paul
