On 25/06/2025 20:00, Simon Horman wrote:
On Wed, Jun 25, 2025 at 05:06:44PM +0300, Vlad URSU wrote:
On 25.06.2025 16:05, Jacek Kowalski wrote:
+#define NVM_CHECKSUM_FACTORY_DEFAULT 0xFFFF
Perhaps it is too long, but I liked Vlad's suggestion of naming this
NVM_CHECKSUM_WORD_FACTORY_DEFAULT.
So the proposals are:
1. NVM_CHECKSUM_WORD_FACTORY_DEFAULT
2. NVM_CHECKSUM_FACTORY_DEFAULT
3. NVM_CHECKSUM_INVALID
4. NVM_CHECKSUM_MISSING
5. NVM_CHECKSUM_EMPTY
6. NVM_NO_CHECKSUM
Any other contenders?
For reference, I called it "CHECKSUM_WORD" in my proposal because that's
what it's refered to as in the intel documentation (section 10.3.2.2 -
http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/ethernet-connection-i219-datasheet.pdf)
FWIIW, I'd vote for 1.
I suggest NVM_CHECKSUM_UNINITIALIZED
(as this is what a value of 0xFFFF really means).
