On 7/7/2025 12:17 PM, Rui Salvaterra wrote:
This is debug information, upon which the user is not expected to act. Output as
such. This avoids polluting the dmesg with full register dumps at every link
down.
Signed-off-by: Rui Salvaterra <[email protected]>
---
This file hasn't been touched in over four years, it's probably from a time when
the driver was under heavy development (started in 2018). Nevertheless, the
status quo is positively annoying. :)
Hi Rui,
Thanks for this patch.
However, I don't completely agree with you.
I think that the main idea here was to have enough data to pass for the
developers in a case where any issue happens without enabling debug
mode. Especially, for those issues that reproduce rarely.
I compared this function to the corresponding functions in ixgbe and igb
and I see that they are implemented similarly.
Therefore, in my opinion, I think that it is better to leave the prints
as they are. Or at least, to push similar changes to the other drivers
as well.
