On 7/21/2025 4:47 AM, Loktionov, Aleksandr wrote:
-----Original Message-----
From: Nguyen, Anthony L <[email protected]>
Sent: Thursday, July 17, 2025 10:08 PM
To: Loktionov, Aleksandr <[email protected]>; Yuto Ohnuki
<[email protected]>; Kitszel, Przemyslaw
<[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller
<[email protected]>; Eric Dumazet <[email protected]>; Jakub
Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel-
[email protected]; [email protected]; linux-
[email protected]
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
unused fields from struct ixgbevf_adapter
On 7/17/2025 2:33 AM, Loktionov, Aleksandr wrote:
-----Original Message-----
From: Intel-wired-lan <[email protected]> On
Behalf
Of Yuto Ohnuki
Sent: Thursday, July 17, 2025 10:46 AM
To: Nguyen, Anthony L <[email protected]>; Kitszel,
Przemyslaw <[email protected]>
Cc: Andrew Lunn <[email protected]>; David S . Miller
<[email protected]>; Eric Dumazet <[email protected]>; Jakub
Kicinski <[email protected]>; Paolo Abeni <[email protected]>; intel-
[email protected]; [email protected]; linux-
[email protected]; Yuto Ohnuki <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
unused
fields from struct ixgbevf_adapter
Remove hw_rx_no_dma_resources and eitr_param fields from struct
ixgbevf_adapter since these fields are never referenced in the
driver.
Note that the interrupt throttle rate is controlled by the
rx_itr_setting and tx_itr_setting variables.
This change simplifies the ixgbevf driver by removing unused
fields,
which improves maintainability.
Signed-off-by: Yuto Ohnuki <[email protected]>
Can you add 'Fixes:' or 'Cleanup:' tag ?
As there's no user bug, I don't believe this warrants a Fixes: tag.
I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm
not seeing one being used(?)
Thanks,
Tony
Good day, Tony
Examples of the tag could be get: git log --grep="^Cleanup:" --oneline
ff9fb2e Merge tag 'samsung-soc-5.19' of
git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/soc
15b5b76 Merge tag 'samsung-soc-5.19' of
git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/drivers
566d336 mm: warn on deleting redirtied only if accounted
35189b8 kernel/acct.c: use #elif instead of #end and #elif
0bbe4ce iommu/amd: Fix the overwritten field in IVMD header
521ec1c Merge tag 'renesas-dt-bindings-for-v4.18' of
https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
878e917 Merge tag 'renesas-dt2-for-v4.13' of
https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
c3acc32 Merge tag 'renesas-arm64-dt2-for-v4.12' of
https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
8855e14 Merge tag 'renesas-dt-for-v4.12' of
https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
5344df6 Merge tag 'renesas-arm64-dt-for-v4.12' of
https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
837a90e netfilter: ipset: Regroup ip_set_put_extensions and add extern
...
From what I saw all the 'Merge tags' are using this as part of the pull
request to categorize the 'Cleanup:' patches. The other patches are
using this line in the commit message to explain the cleanup that is
being done. I'm not opposed to the latter, but it seems the commit
message gives a reasonable explanation already and I don't think it's
worth respinning this to repeat, or reformat, what's already there.
Thanks,
Tony
