> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Lifshits, Vitaly
> Sent: Sunday, July 27, 2025 4:04 PM
> To: ValdikSS <[email protected]>; [email protected]
> Subject: Re: [Intel-wired-lan] [PATCH] igc: fix disabling L1.2 PCI-E
> link substate on I226
>
> On 7/27/2025 5:00 PM, ValdikSS wrote:
> > Device ID comparison in igc_is_device_id_i226 is performed before
> the
> > ID is set, resulting in always failing check.
> >
> > Link:
> > https://lore.kernel.org/intel-wired-lan/15248b4f-3271-42dd-8e35-
> 02bfc9
> > [email protected]
> > Signed-off-by: ValdikSS <[email protected]>
>
> Reviewed-by: Vitaly Lifshits <[email protected]>
>
Reviewed-by: Aleksandr Loktionov <[email protected]>
> > ---
> > drivers/net/ethernet/intel/igc/igc_main.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
> > b/drivers/net/ethernet/intel/igc/igc_main.c
> > index 031c332f6..1b4465d6b 100644
> > --- a/drivers/net/ethernet/intel/igc/igc_main.c
> > +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> > @@ -7115,6 +7115,13 @@ static int igc_probe(struct pci_dev *pdev,
> > adapter->port_num = hw->bus.func;
> > adapter->msg_enable = netif_msg_init(debug,
> DEFAULT_MSG_ENABLE);
> >
> > + /* PCI config space info */
> > + hw->vendor_id = pdev->vendor;
> > + hw->device_id = pdev->device;
> > + hw->revision_id = pdev->revision;
> > + hw->subsystem_vendor_id = pdev->subsystem_vendor;
> > + hw->subsystem_device_id = pdev->subsystem_device;
> > +
> > /* Disable ASPM L1.2 on I226 devices to avoid packet loss */
> > if (igc_is_device_id_i226(hw))
> > pci_disable_link_state(pdev, PCIE_LINK_STATE_L1_2); @@ -
> 7141,13
> > +7148,6 @@ static int igc_probe(struct pci_dev *pdev,
> > netdev->mem_start = pci_resource_start(pdev, 0);
> > netdev->mem_end = pci_resource_end(pdev, 0);
> >
> > - /* PCI config space info */
> > - hw->vendor_id = pdev->vendor;
> > - hw->device_id = pdev->device;
> > - hw->revision_id = pdev->revision;
> > - hw->subsystem_vendor_id = pdev->subsystem_vendor;
> > - hw->subsystem_device_id = pdev->subsystem_device;
> > -
> > /* Copy the default MAC and PHY function pointers */
> > memcpy(&hw->mac.ops, ei->mac_ops, sizeof(hw->mac.ops));
> > memcpy(&hw->phy.ops, ei->phy_ops, sizeof(hw->phy.ops));
>
> Yes, exactly!
> Thank you!
