> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Joshua Hay
> Sent: Friday, July 25, 2025 11:42 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Hay, Joshua A <joshua.a....@intel.com>; Luigi
> Rizzo <lri...@google.com>; Brian Vazquez <bria...@google.com>; Chittim,
> Madhu <madhu.chit...@intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v3 2/6] idpf: improve when to set RE
> bit logic
> 
> Track the gap between next_to_use and the last RE index. Set RE again if the
> gap is large enough to ensure RE bit is set frequently. This is critical 
> before
> removing the stashing mechanisms because the opportunistic descriptor ring
> cleaning from the out-of-order completions will go away. Previously the
> descriptors would be "cleaned" by both the descriptor (RE) completion and
> the out-of-order completions. Without the latter, we must ensure the RE bit is
> set more frequently. Otherwise, it's theoretically possible for the descriptor
> ring next_to_clean to never advance.  The previous implementation was
> dependent on the start of a packet falling on a 64th index in the descriptor
> ring, which is not guaranteed with large packets.
> 
> Signed-off-by: Luigi Rizzo <lri...@google.com>
> Signed-off-by: Brian Vazquez <bria...@google.com>
> Signed-off-by: Joshua Hay <joshua.a....@intel.com>
> Reviewed-by: Madhu Chittim <madhu.chit...@intel.com>
> ---
> 2.39.2

Tested-by: Samuel Salin <samuel.sa...@intel.com>

Reply via email to