> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Simon > Horman > Sent: Wednesday, August 27, 2025 2:27 PM > To: Kohei Enju <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; Nguyen, Anthony L <[email protected]>; > Kitszel, Przemyslaw <[email protected]>; Andrew Lunn > <[email protected]>; David S. Miller <[email protected]>; Eric > Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo > Abeni <[email protected]>; [email protected]; Paul Menzel > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/2] igbvf: add > lbtx_packets and > lbtx_bytes to ethtool statistics > > On Tue, Aug 19, 2025 at 12:18:26AM +0900, Kohei Enju wrote: > > Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX > > Packets/Octets loopback Count), but doesn't show the TX-side > > equivalents (lbtx_packets and lbtx_bytes). Add visibility of those > > missing statistics by adding them to ethtool statistics. > > > > In addition, the order of lbrx_bytes and lbrx_packets is not > > consistent with non-loopback statistics (rx_packets, rx_bytes). > > Therefore, align the order by swapping positions of lbrx_bytes and > > lbrx_packets. > > > > Tested on Intel Corporation I350 Gigabit Network Connection. > > > > Before: > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > rx_packets: 135 > > tx_packets: 106 > > rx_bytes: 16010 > > tx_bytes: 12451 > > lbrx_bytes: 1148 > > lbrx_packets: 12 > > > > After: > > # ethtool -S ens5 | grep -E "x_(bytes|packets)" > > rx_packets: 748 > > tx_packets: 304 > > rx_bytes: 81513 > > tx_bytes: 33698 > > lbrx_packets: 97 > > lbtx_packets: 109 > > lbrx_bytes: 12090 > > lbtx_bytes: 12401 > > > > Reviewed-by: Paul Menzel <[email protected]> > > Signed-off-by: Kohei Enju <[email protected]> > > Reviewed-by: Simon Horman <[email protected]>
Tested-by: Rafal Romanowski <[email protected]>
